Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #376 #379

Open
wants to merge 1 commit into
base: spkl_dev
Choose a base branch
from

Conversation

yurikrivosheyev
Copy link

This PR introduces the IgnoreAssembly method that checks if an assembly should be ignored on Plugins and Workflow assemblies import tasks. If the 'solution prefix' command line argument is specified it is used for assembly name matching and matched assemblies are deployed. If no solution prefix is provided or an assembly does not match the prefix it is matched against a list of ignored publishers via a regex. So it's a 'white list' - 'black list' scheme for assembly checking before deployment. If solution prefix is provided we can do 'white list' check, if no prefix is provided or an assembly didn't pass this check, a 'black list' check is conducted using the ignored publishers list.
A few points to highlight:

  • the ignored publishers list is a more general scheme compared to existing ignored assemblies list and is less likely to require extension in the future,
  • all assemblies in the current ignored assemblies list will be matched when doing ignored publishers list check so this solution is backwards compatible,
  • the IgnoreAssembly method is backwards compatible since it does not require solution prefix to work and without it it will work like existing ignored assemblies list.

…hich ignores all assemblies from a set of publishers defined by a RegEx. Also a possibility of deploying assemblies from only a specified publisher is added, the 'solution prefix' command line argument serves as publisher prefix source.
@yurikrivosheyev yurikrivosheyev marked this pull request as ready for review April 16, 2020 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant